content/browser/frame_host/render_frame_host_impl.cc - Issue 898443003: Use RWH instead of RWHV to know whether a frame is focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 898443003: Use RWH instead of RWHV to know whether a frame is focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 5878180ae16a4662195f58f2e417b14557f21ec0..a4cd6423ec7ac1c6aee265a4d6828e28019fa651 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1594,7 +1594,8 @@ void RenderFrameHostImpl::InvalidateMojoConnection() {

}

bool RenderFrameHostImpl::IsFocused() {

- return GetView()->HasFocus() &&

+ return RenderWidgetHostImpl::From(

+ GetView()->GetRenderWidgetHost())->is_focused() &&

frame_tree_->GetFocusedFrame() &&

(frame_tree_->GetFocusedFrame() == frame_tree_node() ||

frame_tree_->GetFocusedFrame()->IsDescendantOf(frame_tree_node()));

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.h » ('j') | content/browser/renderer_host/render_widget_host_impl.h » ('J')