Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 898443003: Use RWH instead of RWHV to know whether a frame is focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 // Sets up the Mojo connection between this instance and its associated render 401 // Sets up the Mojo connection between this instance and its associated render
402 // frame if it has not yet been set up. 402 // frame if it has not yet been set up.
403 void SetUpMojoIfNeeded(); 403 void SetUpMojoIfNeeded();
404 404
405 // Tears down the browser-side state relating to the Mojo connection between 405 // Tears down the browser-side state relating to the Mojo connection between
406 // this instance and its associated render frame. 406 // this instance and its associated render frame.
407 void InvalidateMojoConnection(); 407 void InvalidateMojoConnection();
408 408
409 // Returns whether the frame is focused. A frame is considered focused when it 409 // Returns whether the frame is focused. A frame is considered focused when it
410 // is the parent chain of the focused frame within the frame tree. In 410 // is the parent chain of the focused frame within the frame tree. In
411 // addition, its associated RenderWidgetHostView has to be focused. 411 // addition, its associated RenderWidgetHost has to be focused.
412 bool IsFocused(); 412 bool IsFocused();
413 413
414 protected: 414 protected:
415 friend class RenderFrameHostFactory; 415 friend class RenderFrameHostFactory;
416 416
417 // |flags| is a combination of CreateRenderFrameFlags. 417 // |flags| is a combination of CreateRenderFrameFlags.
418 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost 418 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost
419 // should be the abstraction needed here, but we need RenderViewHost to pass 419 // should be the abstraction needed here, but we need RenderViewHost to pass
420 // into WebContentsObserver::FrameDetached for now. 420 // into WebContentsObserver::FrameDetached for now.
421 RenderFrameHostImpl(SiteInstance* site_instance, 421 RenderFrameHostImpl(SiteInstance* site_instance,
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
667 667
668 // NOTE: This must be the last member. 668 // NOTE: This must be the last member.
669 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 669 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
670 670
671 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 671 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
672 }; 672 };
673 673
674 } // namespace content 674 } // namespace content
675 675
676 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 676 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698