Use RWH instead of RWHV to know whether a frame is focus.

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/lazy_instance.h"
@@ skipping 260 matching lines @@
 
 RenderViewHost* RenderFrameHostImpl::GetRenderViewHost() {
   return render_view_host_;
 }
 
 ServiceRegistry* RenderFrameHostImpl::GetServiceRegistry() {
   return service_registry_.get();
 }
 
 blink::WebPageVisibilityState RenderFrameHostImpl::GetVisibilityState() {
+  // TODO(mlamouri,kenrb): call directly GetRenderWidgetHost() when it stops

[Charlie Reis, 2015/02/04 17:32:42]

nit: call GetRenderWidgetHost directly

[mlamouri (slow - plz ping), 2015/02/04 17:44:11]

Done.

+  // returning nullptr in some cases, https://crbug.com/455245

[Charlie Reis, 2015/02/04 17:32:42]

nit: Period after "cases," then "See ..."  Also period after link.

[mlamouri (slow - plz ping), 2015/02/04 17:44:11]

Done.

   blink::WebPageVisibilityState visibility_state =
       RenderWidgetHostImpl::From(GetView()->GetRenderWidgetHost())->is_hidden()
           ? blink::WebPageVisibilityStateHidden
           : blink::WebPageVisibilityStateVisible;
   GetContentClient()->browser()->OverridePageVisibilityState(this,
                                                              &visibility_state);
   return visibility_state;
 }
 
 bool RenderFrameHostImpl::Send(IPC::Message* message) {
@@ skipping 1303 matching lines @@
 void RenderFrameHostImpl::InvalidateMojoConnection() {
 #if defined(OS_ANDROID)
   // The Android-specific service registry has a reference to
   // |service_registry_| and thus must be torn down first.
   service_registry_android_.reset();
 #endif
 
   service_registry_.reset();
 }
 
 bool RenderFrameHostImpl::IsFocused() {

[Charlie Reis, 2015/02/04 17:32:42]

The comment for this method in the .h file is now wrong.  Please change "its
associated RenderWidgetHostView has to be focused" to "its associated
RenderWidgetHost has to think it is focused."

[mlamouri (slow - plz ping), 2015/02/04 17:44:11]

Done.

-  return GetView()->HasFocus() &&
+  // TODO(mlamouri,kenrb): call directly GetRenderWidgetHost() when it stops

[Charlie Reis, 2015/02/04 17:32:43]

Same nits as above.

[mlamouri (slow - plz ping), 2015/02/04 17:44:11]

Done.

+  // returning nullptr in some cases, https://crbug.com/455245
+  return RenderWidgetHostImpl::From(
+            GetView()->GetRenderWidgetHost())->is_focused() &&
          frame_tree_->GetFocusedFrame() &&
          (frame_tree_->GetFocusedFrame() == frame_tree_node() ||
           frame_tree_->GetFocusedFrame()->IsDescendantOf(frame_tree_node()));
 }
 
 void RenderFrameHostImpl::UpdateCrossProcessIframeAccessibility(
     const std::map<int32, int>& node_to_frame_routing_id_map) {
   for (const auto& iter : node_to_frame_routing_id_map) {
     // This is the id of the accessibility node that has a child frame.
     int32 node_id = iter.first;
@@ skipping 164 matching lines @@
 void RenderFrameHostImpl::DidUseGeolocationPermission() {
   RenderFrameHost* top_frame = frame_tree_node()->frame_tree()->GetMainFrame();
   GetContentClient()->browser()->RegisterPermissionUsage(
       PERMISSION_GEOLOCATION,
       delegate_->GetAsWebContents(),
       GetLastCommittedURL().GetOrigin(),
       top_frame->GetLastCommittedURL().GetOrigin());
 }
 
 }  // namespace content