Use RWH instead of RWHV to know whether a frame is focus.

content/browser/renderer_host/render_widget_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
 
 #include <deque>
 #include <list>
 #include <map>
@@ skipping 210 matching lines @@
   virtual void WasShown(const ui::LatencyInfo& latency_info);
 
   // Returns true if the RenderWidget is hidden.
   bool is_hidden() const { return is_hidden_; }
 
   // Called to notify the RenderWidget that its associated native window
   // got/lost focused.
   virtual void GotFocus();
   virtual void LostCapture();
 
+  // Indicates whether the frame is currently focused.
+  bool is_focused() const { return is_focused_; }
+
   // Called to notify the RenderWidget that it has lost the mouse lock.
   virtual void LostMouseLock();
 
   // Noifies the RenderWidget of the current mouse cursor visibility state.
   void SendCursorVisibilityState(bool is_visible);
 
   // Notifies the RenderWidgetHost that the View was destroyed.
   void ViewDestroyed();
 
 #if defined(OS_MACOSX)
@@ skipping 593 matching lines @@
 
   int next_browser_snapshot_id_;
   typedef std::map<int,
       base::Callback<void(const unsigned char*, size_t)> > PendingSnapshotMap;
   PendingSnapshotMap pending_browser_snapshots_;
 
   // Indicates whether a RenderFramehost has ownership, in which case this
   // object does not self destroy.
   bool owned_by_render_frame_host_;
 
+  bool is_focused_;

[Charlie Reis, 2015/02/02 18:03:55]

It's getting hard to track why we need this here.  Please put a comment saying
why it's need in both RWHI and RWHV, and when (if ever) they differ.

[mlamouri (slow - plz ping), 2015/02/02 18:21:15]

Basically, RWH focus isn't linked to the system while RWHV is. When a frame gets
focused, it will inform the RWH (ViewHostMsg_{Focus,Blur}) so if we want a 1:1
relationship between what the renderer process think and what the browser
process knows, it's better to use that information.

Regarding situations where it differs, it happened in LayoutTests where a frame
was expected to be focused but wasn't according to the browser process.

+
   base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_