Issue 89843004: Call AtomicString::number() in CSSGrammar.y

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 89843004: Call AtomicString::number() in CSSGrammar.y (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
tkent, eseidel, darktears

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Call AtomicString::number() in CSSGrammar.y Call AtomicString::number() in CSSGrammar.y instead of String::number as CSSSelector::setArgument() expects an AtomicString in argument. This avoids uselessly creating a String and then convert it to an AtomicString. R=eseidel BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162787

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/css/CSSGrammar.y	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/89843004/1

7 years ago (2013-11-27 18:46:22 UTC) #4

Message was sent while issue was closed.

Change committed as 162787

Expand Messages | Collapse Messages