Issue 898423002: Fix mojo::embedder::CreateChannel().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898423002: Fix mojo::embedder::CreateChannel(). (Closed)

Created:
5 years, 10 months ago by viettrungluu

Modified:
5 years, 10 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix mojo::embedder::CreateChannel(). The order of evaluation of channel_info->channel_id and channel_info.release() in the call to g_channel_manager->CreateChannel() is undefined. Oops! (This blew up on Windows/MSVS.) R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/08053238e50879bfd1478d215ce44c87dcab9be6

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	mojo/edk/embedder/embedder.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 10 months ago (2015-02-06 21:32:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
08053238e50879bfd1478d215ce44c87dcab9be6 (presubmit successful).

Expand Messages | Collapse Messages