win: Hack around Gill Sans Ultra Bold DirectWrite problem

win: Hack around Gill Sans Ultra Bold DirectWrite problem

See inline comment for gruesome details. Basically, just ignore the
Ultra Bold weight.

R=shrikant@chromium.org,eae@chromium.org,cpu@chromium.org
BUG=408093
Committed: https://crrev.com/0264cb1161367ed0dc5431069405212c7e3aab88
Cr-Commit-Position: refs/heads/master@{#315176}

[scottmg, 2015-02-06 19:27:33]

https://codereview.chromium.org/898403002/diff/40001/content/common/dwrite_fo...
File content/common/dwrite_font_platform_win.cc (right):

https://codereview.chromium.org/898403002/diff/40001/content/common/dwrite_fo...
content/common/dwrite_font_platform_win.cc:87: const DWORD kCacheFileVersion =
104;
shrikant: Is this necessary?

[Shrikant Kelkar, 2015-02-06 20:56:23]

lgtm!

https://codereview.chromium.org/898403002/diff/40001/content/common/dwrite_fo...
File content/common/dwrite_font_platform_win.cc (right):

https://codereview.chromium.org/898403002/diff/40001/content/common/dwrite_fo...
content/common/dwrite_font_platform_win.cc:87: const DWORD kCacheFileVersion =
104;
On 2015/02/06 19:27:33, scottmg wrote:
> shrikant: Is this necessary?

Not necessary in this case.. Registry fonts will be loaded irrespective of
presence in cache, but if you want to force remove from cache then you need this
and then please modify font format file in unit test as well.

https://codereview.chromium.org/898403002/diff/40001/content/common/dwrite_fo...
content/common/dwrite_font_platform_win.cc:792: path.value(),
FILE_PATH_LITERAL("gillubcd.ttf"))) {
Since more than one, please consider using fonts_to_ignore list/vector/map?

[scottmg, 2015-02-06 21:38:50]

New patchsets have been uploaded after l-g-t-m from shrikant@chromium.org

[scottmg, 2015-02-06 21:39:33]

https://codereview.chromium.org/898403002/diff/40001/content/common/dwrite_fo...
File content/common/dwrite_font_platform_win.cc (right):

https://codereview.chromium.org/898403002/diff/40001/content/common/dwrite_fo...
content/common/dwrite_font_platform_win.cc:87: const DWORD kCacheFileVersion =
104;
On 2015/02/06 20:56:22, Shrikant Kelkar wrote:
> On 2015/02/06 19:27:33, scottmg wrote:
> > shrikant: Is this necessary?
> 
> Not necessary in this case.. Registry fonts will be loaded irrespective of
> presence in cache, but if you want to force remove from cache then you need
this
> and then please modify font format file in unit test as well.

OK, undid this change.

https://codereview.chromium.org/898403002/diff/40001/content/common/dwrite_fo...
content/common/dwrite_font_platform_win.cc:792: path.value(),
FILE_PATH_LITERAL("gillubcd.ttf"))) {
On 2015/02/06 20:56:22, Shrikant Kelkar wrote:
> Since more than one, please consider using fonts_to_ignore list/vector/map?

Done.

[scottmg, 2015-02-06 21:40:41]

Patchset #4 (id:60001) has been deleted

[eae, 2015-02-06 23:34:26]

LGTM

[cpu_(ooo_6.6-7.5), 2015-02-07 01:28:56]

lgtm

[cpu_(ooo_6.6-7.5), 2015-02-07 01:28:59]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2015-02-07 01:29:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/898403002/80001

[commit-bot: I haz the power, 2015-02-07 03:50:41]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-02-07 03:51:10]

Patchset 4 (id:??) landed as
https://crrev.com/0264cb1161367ed0dc5431069405212c7e3aab88
Cr-Commit-Position: refs/heads/master@{#315176}