Issue 898363002: mojo_application.gni - data deps are called data_deps these days.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898363002: mojo_application.gni - data deps are called data_deps these days. (Closed)

Created:
5 years, 10 months ago by ppi

Modified:
5 years, 10 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

mojo_application.gni - data deps are called data_deps these days. GN renamed datadeps to data_deps in https://codereview.chromium.org/561273003 . datadeps works only for backward compatibility. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f2782126466482be6867465645f012d07c985c0c

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -19 lines)			Patch
M	examples/apptest/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	mojo/public/mojo_application.gni	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	services/clipboard/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	services/dart/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	services/reaper/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	services/window_manager/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years, 10 months ago (2015-02-06 16:08:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f2782126466482be6867465645f012d07c985c0c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages