Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 898343004: Rename SkCanvasDrawable to SkDrawable, and make public (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename SkCanvasDrawable to SkDrawable, and make public (patchset #2 id:20001 of https://codereview.chromium.org/903993002/)" This reverts commit c4e87724920222a218f31b22612efc5b1ec0ed6c. BUG=skia: TBR= NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/3cb3840c9af6f70896cf5565a38d4ee03c02d767

Patch Set 1 #

Patch Set 2 : fix gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -219 lines) Patch
M gyp/core.gypi View 1 3 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkCanvas.h View 3 chunks +11 lines, -3 lines 0 comments Download
A + include/core/SkDrawable.h View 3 chunks +11 lines, -4 lines 0 comments Download
M include/core/SkPictureRecorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleArc.cpp View 6 chunks +6 lines, -7 lines 0 comments Download
M samplecode/SampleHT.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
D src/core/SkCanvasDrawable.h View 1 chunk +0 lines, -69 lines 0 comments Download
D src/core/SkCanvasDrawable.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
A + src/core/SkDrawable.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 7 chunks +17 lines, -17 lines 0 comments Download
M src/core/SkRecordDraw.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRecorder.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/core/SkRecorder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkRecords.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898343004/20001
5 years, 10 months ago (2015-02-06 16:26:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898343004/20001
5 years, 10 months ago (2015-02-06 16:35:57 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 16:36:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3cb3840c9af6f70896cf5565a38d4ee03c02d767

Powered by Google App Engine
This is Rietveld 408576698