Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 898343002: Copy http_status_code_list.h from /net to be owned by http_server. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Copy http_status_code_list.h from /net to be owned by http_server. BUG=456130 R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3c3a7ffa0028263366a5a91acfd7463813f8e2ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M services/http_server/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/http_server/http_server.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/http_server/http_status_code_list.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Ben, ptal.
5 years, 10 months ago (2015-02-06 15:38:21 UTC) #2
qsr
:( Should this list be an enum defined in the mojom for the network service ...
5 years, 10 months ago (2015-02-06 15:54:12 UTC) #3
ppi
Not sure if it fits in the mojom. This is not part of the interface ...
5 years, 10 months ago (2015-02-06 16:06:53 UTC) #4
qsr
On 2015/02/06 16:06:53, ppi wrote: > Not sure if it fits in the mojom. This ...
5 years, 10 months ago (2015-02-06 16:13:36 UTC) #5
ppi
5 years, 10 months ago (2015-02-06 16:15:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c3a7ffa0028263366a5a91acfd7463813f8e2ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698