Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 898273002: app_list::SearchResult: Duplicate() is const. (Closed)

Created:
5 years, 10 months ago by Matt Giuca
Modified:
5 years, 10 months ago
Reviewers:
calamity, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

app_list::SearchResult: Duplicate() is const. There is no reason for this method to be non-const. TBR=sky@chromium.org Committed: https://crrev.com/2e8a2a7bf847e770b29a6a640b74a971968190f3 Cr-Commit-Position: refs/heads/master@{#315266}

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M ash/shell/app_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/app_result.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/app_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/omnibox_result.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/omnibox_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_result.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/people/people_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/search_webstore_result.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/search_webstore_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_result.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search/mixer.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/app_list/search/mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search_result.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/test/test_search_result.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/test/test_search_result.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
calamity: To review. sky: TBR (mechanical change to ash/shell/app_list.cc).
5 years, 10 months ago (2015-02-06 08:18:07 UTC) #2
calamity
lgtm
5 years, 10 months ago (2015-02-09 04:09:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898273002/20001
5 years, 10 months ago (2015-02-09 04:11:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 04:55:54 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 04:56:20 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2e8a2a7bf847e770b29a6a640b74a971968190f3
Cr-Commit-Position: refs/heads/master@{#315266}

Powered by Google App Engine
This is Rietveld 408576698