|
|
Descriptionremove useless APIs in WGC3DImpl
BUG=
Committed: https://crrev.com/067bd932c5cd1c16b5a1d5e8340dbff1e24923a0
Cr-Commit-Position: refs/heads/master@{#315268}
Patch Set 1 #Patch Set 2 : add my email into AUTHORS file" #
Messages
Total messages: 20 (6 generated)
yunchao.he@intel.com changed reviewers: + piman@chromium.org, sievers@chromium.org
PTAL. Thanks a lot.
yunchao.he@intel.com changed reviewers: + bajones@chromium.org, kbr@chromium.org
Are you removing these in blink (WebGraphicsContext3D.h) also?
not lgtm This code seems to be being called in https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/test_web_g... ? Did you test this patch?
On 2015/02/06 21:43:24, Ken Russell wrote: > not lgtm > > This code seems to be being called in > https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/test_web_g... > ? Did you test this patch? Note: TestWebGraphicsContext3D is not a WebGraphicsContext3D anymore, so it shouldn't be a problem. Please make sure to remove the same calls from WebGraphicsContext3D in blink, but otherwise lgtm if it passes trybots.
On 2015/02/06 21:51:20, piman (Very slow to review) wrote: > On 2015/02/06 21:43:24, Ken Russell wrote: > > not lgtm > > > > This code seems to be being called in > > > https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/test_web_g... > > ? Did you test this patch? > > Note: TestWebGraphicsContext3D is not a WebGraphicsContext3D anymore, so it > shouldn't be a problem. > > Please make sure to remove the same calls from WebGraphicsContext3D in blink, > but otherwise lgtm if it passes trybots. @yunchao: do you have the permissions to trigger try jobs? If so, please do so. Thanks.
On 2015/02/06 19:02:27, sievers wrote: > Are you removing these in blink (WebGraphicsContext3D.h) also? Yes, I will submit another one for Blink part if this is correct.
On 2015/02/06 22:22:40, Ken Russell wrote: > On 2015/02/06 21:51:20, piman (Very slow to review) wrote: > > On 2015/02/06 21:43:24, Ken Russell wrote: > > > not lgtm > > > > > > This code seems to be being called in > > > > > > https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/test_web_g... > > > ? Did you test this patch? > > > > Note: TestWebGraphicsContext3D is not a WebGraphicsContext3D anymore, so it > > shouldn't be a problem. > > > > Please make sure to remove the same calls from WebGraphicsContext3D in blink, > > but otherwise lgtm if it passes trybots. > > @yunchao: do you have the permissions to trigger try jobs? If so, please do so. > Thanks. Kenneth, I am not Chromium/Blink committer currently. I don't have the permissions to trigger try jobs. Could you kindly grant me the permissions. That will be much convenient for me to contribute to Chromium/Blink. Thanks in advance!
On 2015/02/07 00:53:29, yunchao wrote: > On 2015/02/06 22:22:40, Ken Russell wrote: > > On 2015/02/06 21:51:20, piman (Very slow to review) wrote: > > > On 2015/02/06 21:43:24, Ken Russell wrote: > > > > not lgtm > > > > > > > > This code seems to be being called in > > > > > > > > > > https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/test_web_g... > > > > ? Did you test this patch? > > > > > > Note: TestWebGraphicsContext3D is not a WebGraphicsContext3D anymore, so it > > > shouldn't be a problem. > > > > > > Please make sure to remove the same calls from WebGraphicsContext3D in > blink, > > > but otherwise lgtm if it passes trybots. > > > > @yunchao: do you have the permissions to trigger try jobs? If so, please do > so. > > Thanks. > > Kenneth, I am not Chromium/Blink committer currently. I don't have the > permissions to trigger try jobs. Could you kindly grant me the permissions. That > will be much convenient for me to contribute to Chromium/Blink. Thanks in > advance! Yunchao, I've nominated you for try job access per http://www.chromium.org/getting-involved/become-a-committer#TOC-Try-job-access . Hopefully this will go through next week. In the interim, if this compiles on all platforms, I withdraw my original objection and LGTM it.
On 2015/02/07 01:22:39, Ken Russell wrote: > On 2015/02/07 00:53:29, yunchao wrote: > > On 2015/02/06 22:22:40, Ken Russell wrote: > > > On 2015/02/06 21:51:20, piman (Very slow to review) wrote: > > > > On 2015/02/06 21:43:24, Ken Russell wrote: > > > > > not lgtm > > > > > > > > > > This code seems to be being called in > > > > > > > > > > > > > > > https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/test_web_g... > > > > > ? Did you test this patch? > > > > > > > > Note: TestWebGraphicsContext3D is not a WebGraphicsContext3D anymore, so > it > > > > shouldn't be a problem. > > > > > > > > Please make sure to remove the same calls from WebGraphicsContext3D in > > blink, > > > > but otherwise lgtm if it passes trybots. > > > > > > @yunchao: do you have the permissions to trigger try jobs? If so, please do > > so. > > > Thanks. > > > > Kenneth, I am not Chromium/Blink committer currently. I don't have the > > permissions to trigger try jobs. Could you kindly grant me the permissions. > That > > will be much convenient for me to contribute to Chromium/Blink. Thanks in > > advance! > > Yunchao, I've nominated you for try job access per > http://www.chromium.org/getting-involved/become-a-committer#TOC-Try-job-access . > Hopefully this will go through next week. Thanks a lot, Kenneth! I really appreciate this. > > In the interim, if this compiles on all platforms, I withdraw my original > objection and LGTM it. I will run the try jobs later.
The CQ bit was checked by piman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898263002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
New patchsets have been uploaded after l-g-t-m from piman@chromium.org,kbr@chromium.org
The CQ bit was checked by yunchao.he@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898263002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/067bd932c5cd1c16b5a1d5e8340dbff1e24923a0 Cr-Commit-Position: refs/heads/master@{#315268} |