Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 898263002: remove useless APIs in WGC3DImpl (Closed)

Created:
5 years, 10 months ago by yunchao
Modified:
5 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove useless APIs in WGC3DImpl BUG= Committed: https://crrev.com/067bd932c5cd1c16b5a1d5e8340dbff1e24923a0 Cr-Commit-Position: refs/heads/master@{#315268}

Patch Set 1 #

Patch Set 2 : add my email into AUTHORS file" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.h View 1 chunk +0 lines, -11 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_impl.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
yunchao
PTAL. Thanks a lot.
5 years, 10 months ago (2015-02-06 06:16:49 UTC) #2
no sievers
Are you removing these in blink (WebGraphicsContext3D.h) also?
5 years, 10 months ago (2015-02-06 19:02:27 UTC) #4
Ken Russell (switch to Gerrit)
not lgtm This code seems to be being called in https://code.google.com/p/chromium/codesearch#chromium/src/cc/test/test_web_graphics_context_3d.cc&q=genBuffers&sq=package:chromium&type=cs&l=157 ? Did you test ...
5 years, 10 months ago (2015-02-06 21:43:24 UTC) #5
piman
On 2015/02/06 21:43:24, Ken Russell wrote: > not lgtm > > This code seems to ...
5 years, 10 months ago (2015-02-06 21:51:20 UTC) #6
Ken Russell (switch to Gerrit)
On 2015/02/06 21:51:20, piman (Very slow to review) wrote: > On 2015/02/06 21:43:24, Ken Russell ...
5 years, 10 months ago (2015-02-06 22:22:40 UTC) #7
yunchao
On 2015/02/06 19:02:27, sievers wrote: > Are you removing these in blink (WebGraphicsContext3D.h) also? Yes, ...
5 years, 10 months ago (2015-02-07 00:47:35 UTC) #8
yunchao
On 2015/02/06 22:22:40, Ken Russell wrote: > On 2015/02/06 21:51:20, piman (Very slow to review) ...
5 years, 10 months ago (2015-02-07 00:53:29 UTC) #9
Ken Russell (switch to Gerrit)
On 2015/02/07 00:53:29, yunchao wrote: > On 2015/02/06 22:22:40, Ken Russell wrote: > > On ...
5 years, 10 months ago (2015-02-07 01:22:39 UTC) #10
yunchao
On 2015/02/07 01:22:39, Ken Russell wrote: > On 2015/02/07 00:53:29, yunchao wrote: > > On ...
5 years, 10 months ago (2015-02-07 01:28:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898263002/1
5 years, 10 months ago (2015-02-07 01:30:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41149)
5 years, 10 months ago (2015-02-07 01:36:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898263002/20001
5 years, 10 months ago (2015-02-09 04:24:22 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 05:13:54 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 05:14:26 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/067bd932c5cd1c16b5a1d5e8340dbff1e24923a0
Cr-Commit-Position: refs/heads/master@{#315268}

Powered by Google App Engine
This is Rietveld 408576698