Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 898253002: Update apps grid view layout to match latest mocks. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@search_box_animate_shadow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update apps grid view layout to match latest mocks. This CL updates the experimental app list's apps grid view layout to precisely match mocks. The experimental app list is now 768x570. BUG=442022 Committed: https://crrev.com/ba3c2e3760bd7301dacdb596bc227d9167f30830 Cr-Commit-Position: refs/heads/master@{#315270}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -24 lines) Patch
M ui/app_list/app_list_constants.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/app_list_constants.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/views/apps_grid_view.cc View 7 chunks +20 lines, -11 lines 0 comments Download
M ui/app_list/views/contents_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/views/folder_header_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/page_switcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_result_page_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
calamity
5 years, 10 months ago (2015-02-06 05:49:31 UTC) #2
Matt Giuca
lgtm Didn't do a very thorough check, but it's all just dimensions changing so I ...
5 years, 10 months ago (2015-02-06 06:14:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898253002/1
5 years, 10 months ago (2015-02-06 06:23:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/56151) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-06 06:26:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898253002/1
5 years, 10 months ago (2015-02-09 03:55:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/56672) ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-09 03:57:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898253002/20001
5 years, 10 months ago (2015-02-09 06:11:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 06:19:35 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 06:20:15 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba3c2e3760bd7301dacdb596bc227d9167f30830
Cr-Commit-Position: refs/heads/master@{#315270}

Powered by Google App Engine
This is Rietveld 408576698