Issue 898233003: Making the (deprecation-in-progress) congestion field write only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 898233003: Making the (deprecation-in-progress) congestion field write only. (Closed)

Created:
5 years, 10 months ago by ramant (doing other things)

Modified:
5 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Improving_junk_packet_handling_85067984

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Making the (deprecation-in-progress) congestion field write only. This is a bit of a hack because technically it's "required" for QUIC_VERSION_23 but as all the internal servers and all of chrome builds picking up this change consider the field optional despite the version, it should just Work (TM). I was hoping to stop sending the congestion fields for v24 clients but that is not safe until the internal server fleet doesn't consider it a required field for negotiated()=true. Bah. No longer reading the (deprecated) congestion fields for QUIC. Merge internal change: 85158634 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -14 lines)			Patch
M	net/quic/quic_config.cc	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	net/quic/test_tools/quic_config_peer.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/quic_config_peer.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages