Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 898173002: Update {virtual,override,final} to follow C++11 style in tools. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in tools. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/aef52682b97c29f94ceb9a9750e29eecad58b416 Cr-Commit-Position: refs/heads/master@{#314943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/android/forwarder2/device_forwarder_main.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/android/heap_profiler/heap_profiler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 10 months ago (2015-02-06 01:09:38 UTC) #2
Lei Zhang
lgtm, nut sure if I'm an owner here though.
5 years, 10 months ago (2015-02-06 01:14:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898173002/1
5 years, 10 months ago (2015-02-06 01:20:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 01:56:27 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 01:57:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aef52682b97c29f94ceb9a9750e29eecad58b416
Cr-Commit-Position: refs/heads/master@{#314943}

Powered by Google App Engine
This is Rietveld 408576698