Fix unable to opt-in to crash reports & usage statistics from web-app

remoting/webapp/crd/js/host_setup_dialog.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
@@ skipping 172 matching lines @@
   var that = this;
 
   /**
    * @param {boolean} supported True if crash dump reporting is supported by
    *     the host.
    * @param {boolean} allowed True if crash dump reporting is allowed.
    * @param {boolean} set_by_policy True if crash dump reporting is controlled
    *     by policy.
    */
   function onGetConsent(supported, allowed, set_by_policy) {
-    that.usageStats_.hidden = !supported;
+    // Hide the usage stats check box if it is not supported or the policy
+    // doesn't allow usage stats collection.
+    that.usageStats_.hidden = !supported || (set_by_policy && !allowed);
     that.usageStatsCheckbox_.checked = allowed;
-    that.usageStatsCheckbox_.disabled = set_by_policy;
+
+    if (set_by_policy) {
+      that.usageStatsCheckbox_.disabled = true;
+      that.usageStatsCheckbox_.title = l10n.getTranslationOrError(

[Jamie, 2015/02/06 02:22:02]

Do the disables and title attributes apply to both the checkbox and its label? I
thought we decided that the original behaviour was confusing in part because the
label wasn't greyed out.

[kelvinp, 2015/02/06 19:50:21]

Done.

+          /*i18n-content*/ 'SETTING_MANAGED_BY_POLICY');
+    } else {
+      that.usageStatsCheckbox_.disabled = false;
+      that.usageStatsCheckbox_.title = '';
+    }
   }
 
   /** @param {remoting.Error} error */
   function onError(error) {
     console.error('Error getting consent status: ' + error);
   }
 
   this.usageStats_.hidden = false;
   this.usageStatsCheckbox_.checked = false;
 
@@ skipping 344 matching lines @@
     var c = pin.charAt(i);
     if ((c < '0') || (c > '9')) {
       return false;
     }
   }
   return true;
 };
 
 /** @type {remoting.HostSetupDialog} */
 remoting.hostSetupDialog = null;