Use recently imported MSVC warning macros

Use recently imported MSVC warning macros

The PUSH/POP are less noisy for sure. SUPPRESS is a little more
subtle -- it's correctly documented as "for this line and the next"
but that doesn't work well with our coding style.

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/22c82f0c6c17625518531c51377376e8ce352601

[scottmg, 2015-02-05 18:03:14]

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_context_wr...
File minidump/minidump_context_writer.cc (right):

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_context_wr...
minidump/minidump_context_writer.cc:43: MSVC_SUPPRESS_WARNING(4316) new
MinidumpContextAMD64Writer();
This one is tricky. Putting it above line 42 is insufficient.

As-is this also disables the warning for line 44.

So the most correct location would be preceding "MinidumpContextAMD64Writer*
..." as a prefix, but that looked a bit ugly.

[Mark Mentovai, 2015-02-05 18:24:10]

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_context_wr...
File minidump/minidump_context_writer.cc (right):

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_context_wr...
minidump/minidump_context_writer.cc:43: MSVC_SUPPRESS_WARNING(4316) new
MinidumpContextAMD64Writer();
scottmg wrote:
> This one is tricky. Putting it above line 42 is insufficient.
> 
> As-is this also disables the warning for line 44.
> 
> So the most correct location would be preceding "MinidumpContextAMD64Writer*
> ..." as a prefix, but that looked a bit ugly.

PUSH/POP may still be better since this is so sensitive to placement.

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_extensions.h
File minidump/minidump_extensions.h (right):

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_extensions...
minidump/minidump_extensions.h:32: MSVC_PUSH_DISABLE_WARNING(4200)
Semicolons?

[scottmg, 2015-02-05 18:47:40]

Patchset #2 (id:20001) has been deleted

[scottmg, 2015-02-05 18:51:43]

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_context_wr...
File minidump/minidump_context_writer.cc (right):

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_context_wr...
minidump/minidump_context_writer.cc:43: MSVC_SUPPRESS_WARNING(4316) new
MinidumpContextAMD64Writer();
On 2015/02/05 18:24:10, Mark Mentovai wrote:
> scottmg wrote:
> > This one is tricky. Putting it above line 42 is insufficient.
> > 
> > As-is this also disables the warning for line 44.
> > 
> > So the most correct location would be preceding "MinidumpContextAMD64Writer*
> > ..." as a prefix, but that looked a bit ugly.
> 
> PUSH/POP may still be better since this is so sensitive to placement.

Done.

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_extensions.h
File minidump/minidump_extensions.h (right):

https://codereview.chromium.org/898133002/diff/1/minidump/minidump_extensions...
minidump/minidump_extensions.h:32: MSVC_PUSH_DISABLE_WARNING(4200)
On 2015/02/05 18:24:10, Mark Mentovai wrote:
> Semicolons?

I think that would result in a stray semicolon at global scope.

... VC doesn't seem to mind though? I'll check clang.

... It doesn't seem to mind either. Seems strange to me, but I guess is
convenient. So, Done!

[Mark Mentovai, 2015-02-05 19:23:31]

LGTM

https://codereview.chromium.org/898133002/diff/60001/minidump/minidump_file_w...
File minidump/minidump_file_writer_test.cc (right):

https://codereview.chromium.org/898133002/diff/60001/minidump/minidump_file_w...
minidump/minidump_file_writer_test.cc:291: MSVC_SUPPRESS_WARNING(4309);  //
Truncation of constant value.
#include "base/compiler_specific.h"

[scottmg, 2015-02-05 19:29:46]

New patchsets have been uploaded after l-g-t-m from mark@chromium.org

[scottmg, 2015-02-05 19:30:02]

https://codereview.chromium.org/898133002/diff/60001/minidump/minidump_file_w...
File minidump/minidump_file_writer_test.cc (right):

https://codereview.chromium.org/898133002/diff/60001/minidump/minidump_file_w...
minidump/minidump_file_writer_test.cc:291: MSVC_SUPPRESS_WARNING(4309);  //
Truncation of constant value.
On 2015/02/05 19:23:31, Mark Mentovai wrote:
> #include "base/compiler_specific.h"

Oops, done.

[scottmg, 2015-02-05 19:30:34]

Committed patchset #4 (id:80001) manually as
22c82f0c6c17625518531c51377376e8ce352601 (presubmit successful).