Fix race condition in Redirection global list using CAS.

Fix race condition in Redirection global list using CAS.

Note that a simple Mutex cannot be used, since the profiler may interrupt the thread at any point, and also walks this list.

Committed: https://code.google.com/p/dart/source/detail?r=43557

[koda, 2015-02-05 16:44:34]

BTW, see the disassembly in the bug report to see what goes wrong without the
CAS:

https://code.google.com/p/dart/issues/detail?id=22087

[koda, 2015-02-05 16:53:15]

koda@google.com changed reviewers:
+ johnmccutchan@google.com

[koda, 2015-02-05 23:52:47]

koda@google.com changed reviewers:
+ asiva@google.com

[koda, 2015-02-06 00:24:38]

Updated CL with the other simulators as well (identical code).

Siva: Since Ivan is unavailable, could you please take a look?

[Cutch, 2015-02-06 00:47:10]

LGTMwC

https://codereview.chromium.org/898123002/diff/20001/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/898123002/diff/20001/runtime/vm/simulator_arm...
runtime/vm/simulator_arm.cc:819: next_ = old_list;
consider renaming "old_list" to "list_head".

[koda, 2015-02-06 15:50:14]

Committed patchset #2 (id:20001) manually as r43557 (presubmit successful).

[koda, 2015-02-06 15:50:22]

https://codereview.chromium.org/898123002/diff/20001/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/898123002/diff/20001/runtime/vm/simulator_arm...
runtime/vm/simulator_arm.cc:819: next_ = old_list;
On 2015/02/06 00:47:10, Cutch wrote:
> consider renaming "old_list" to "list_head".

Done.