Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 898113002: Add sharedfrontend package (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index 11c8a8417b892ac9c488be293eefd3f1e8ab9096..c49b45843eee15905683366cfd11cd8de358f013 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -10,6 +10,8 @@ import 'package:compiler/src/dart_types.dart' as dart2js;
import 'package:compiler/src/elements/elements.dart' as dart2js;
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/element.dart' as analyzer;
+import 'package:sharedfrontend/elements.dart' as shared;
+import 'package:sharedfrontend/src/access_semantics.dart';
import 'package:compiler/src/dart2jslib.dart'
show DART_CONSTANT_SYSTEM;
@@ -387,7 +389,7 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
// TODO(johnniwinther): Handle implicit `this`.
ir.Primitive receiver = build(semantics.target);
return irBuilder.buildDynamicGet(receiver,
- new Selector.getter(semantics.identifier.name,
+ new Selector.getter(semantics.name,
converter.convertElement(element.library)));
}
@@ -520,9 +522,10 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
node.identifier.name, converter.convertElement(currentLibrary));
} else if (accessSemantics.element != null) {
variableElement = converter.convertElement(accessSemantics.element);
+ shared.Element library = accessSemantics.element.library;
variableSelector = new Selector.setter(
variableElement.name,
- converter.convertElement(accessSemantics.element.library));
+ converter.convertElement(library));
} else {
giveUp(node, 'For-in of unresolved variable: $accessSemantics');
}

Powered by Google App Engine
This is Rietveld 408576698