Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 898023002: Add LIBMTP_Get_Thumbnail_Format to get thumbnail format of a file. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
kinaba
Base URL:
https://chromium.googlesource.com/chromium/deps/libmtp@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add LIBMTP_Get_Thumbnail_Format to get thumbnail format of a file. BUG=451930

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change unsigned int to uint16_t. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
A patches/20_get_thumbnail_format.patch View 1 1 chunk +68 lines, -0 lines 0 comments Download
M src/libmtp.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/libmtp.c View 1 1 chunk +21 lines, -0 lines 0 comments Download
M src/libmtp.sym View 1 chunk +1 line, -0 lines 0 comments Download
M src/libmtp.h.in View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yawano
@thestig: PTAL. Thank you!
5 years, 10 months ago (2015-02-05 05:41:49 UTC) #2
Lei Zhang
Just one question: https://codereview.chromium.org/898023002/diff/1/src/libmtp.h File src/libmtp.h (right): https://codereview.chromium.org/898023002/diff/1/src/libmtp.h#newcode928 src/libmtp.h:928: unsigned int *format); Isn't the ThumbFormat ...
5 years, 10 months ago (2015-02-05 06:20:11 UTC) #3
yawano
Thank you for the review! PTAL. https://codereview.chromium.org/898023002/diff/1/src/libmtp.h File src/libmtp.h (right): https://codereview.chromium.org/898023002/diff/1/src/libmtp.h#newcode928 src/libmtp.h:928: unsigned int *format); ...
5 years, 10 months ago (2015-02-05 06:34:58 UTC) #4
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-05 06:36:41 UTC) #5
yawano
On 2015/02/05 06:36:41, Lei Zhang wrote: > lgtm Thank you!
5 years, 10 months ago (2015-02-05 06:37:09 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 06:41:57 UTC) #9 
Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

Powered by Google App Engine
This is Rietveld 408576698