Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 898013004: Remove uses of InterfaceImpl in wm_flow example (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove uses of InterfaceImpl in wm_flow example Also cleans up some virtual+override keywords redundantly specified and override instead of virtual on d'tors that override. Tested by mojo_demo.sh --wm_flow. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dd75a32cc4a2930502176fc5cf6d9274c311b397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M examples/wm_flow/app/app.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M examples/wm_flow/embedded/embedded.cc View 4 chunks +22 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
5 years, 10 months ago (2015-02-12 21:49:03 UTC) #1
sky
LGTM
5 years, 10 months ago (2015-02-19 00:12:09 UTC) #2
jamesr
5 years, 10 months ago (2015-02-19 01:13:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd75a32cc4a2930502176fc5cf6d9274c311b397 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698