Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 898013003: CallIC MISS handler doesn't need receiver. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 2771 matching lines...) Expand 10 before | Expand all | Expand 10 after
2782 __ JumpIfSmi(r1, &non_function); 2782 __ JumpIfSmi(r1, &non_function);
2783 2783
2784 // Goto slow case if we do not have a function. 2784 // Goto slow case if we do not have a function.
2785 __ CompareObjectType(r1, r4, r4, JS_FUNCTION_TYPE); 2785 __ CompareObjectType(r1, r4, r4, JS_FUNCTION_TYPE);
2786 __ b(ne, &slow); 2786 __ b(ne, &slow);
2787 __ jmp(&have_js_function); 2787 __ jmp(&have_js_function);
2788 } 2788 }
2789 2789
2790 2790
2791 void CallICStub::GenerateMiss(MacroAssembler* masm) { 2791 void CallICStub::GenerateMiss(MacroAssembler* masm) {
2792 // Get the receiver of the function from the stack. 2792 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
2793 __ ldr(r4, MemOperand(sp, arg_count() * kPointerSize));
2794 2793
2795 { 2794 // Push the receiver and the function and feedback info.
2796 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL); 2795 __ Push(r1, r2, r3);
2797 2796
2798 // Push the receiver and the function and feedback info. 2797 // Call the entry.
2799 __ Push(r4, r1, r2, r3); 2798 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss
2799 : IC::kCallIC_Customization_Miss;
2800 2800
2801 // Call the entry. 2801 ExternalReference miss = ExternalReference(IC_Utility(id), masm->isolate());
2802 IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss 2802 __ CallExternalReference(miss, 3);
2803 : IC::kCallIC_Customization_Miss;
2804 2803
2805 ExternalReference miss = ExternalReference(IC_Utility(id), 2804 // Move result to edi and exit the internal frame.
2806 masm->isolate()); 2805 __ mov(r1, r0);
2807 __ CallExternalReference(miss, 4);
2808
2809 // Move result to edi and exit the internal frame.
2810 __ mov(r1, r0);
2811 }
2812 } 2806 }
2813 2807
2814 2808
2815 // StringCharCodeAtGenerator 2809 // StringCharCodeAtGenerator
2816 void StringCharCodeAtGenerator::GenerateFast(MacroAssembler* masm) { 2810 void StringCharCodeAtGenerator::GenerateFast(MacroAssembler* masm) {
2817 // If the receiver is a smi trigger the non-string case. 2811 // If the receiver is a smi trigger the non-string case.
2818 if (check_mode_ == RECEIVER_IS_UNKNOWN) { 2812 if (check_mode_ == RECEIVER_IS_UNKNOWN) {
2819 __ JumpIfSmi(object_, receiver_not_string_); 2813 __ JumpIfSmi(object_, receiver_not_string_);
2820 2814
2821 // Fetch the instance type of the receiver into result register. 2815 // Fetch the instance type of the receiver into result register.
(...skipping 2147 matching lines...) Expand 10 before | Expand all | Expand 10 after
4969 kStackUnwindSpace, NULL, 4963 kStackUnwindSpace, NULL,
4970 MemOperand(fp, 6 * kPointerSize), NULL); 4964 MemOperand(fp, 6 * kPointerSize), NULL);
4971 } 4965 }
4972 4966
4973 4967
4974 #undef __ 4968 #undef __
4975 4969
4976 } } // namespace v8::internal 4970 } } // namespace v8::internal
4977 4971
4978 #endif // V8_TARGET_ARCH_ARM 4972 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698