Issue 898013003: CallIC MISS handler doesn't need receiver.

Issue 898013003: CallIC MISS handler doesn't need receiver. (Closed)

Created:
5 years, 10 months ago by mvstanton

Modified:
5 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

CallIC MISS handler doesn't need receiver. Looking up and passing this argument is unnecessary. R=ulan@chromium.org Committed: https://crrev.com/0e8d97c17b47d6ed6f4927eaf262a53e90c66541 Cr-Commit-Position: refs/heads/master@{#26464}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -137 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	1 chunk	+10 lines, -16 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	1	1 chunk	+10 lines, -16 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+12 lines, -19 lines	0 comments	Download
M	src/ic/ic.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ic/ic.cc	View		5 chunks	+12 lines, -13 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1	1 chunk	+10 lines, -16 lines	0 comments	Download
M	src/mips64/code-stubs-mips64.cc	View	1	1 chunk	+10 lines, -16 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+13 lines, -20 lines	0 comments	Download
M	src/x87/code-stubs-x87.cc	View	1	1 chunk	+12 lines, -19 lines	0 comments	Download

Total messages: 6 (1 generated)

mvstanton

Hi Ulan, Here is the follow-up to that interesting bug from yesterday: simply ignore receiver. ...

5 years, 10 months ago (2015-02-05 13:29:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/898013003/40001

5 years, 10 months ago (2015-02-05 13:39:39 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-05 15:11:18 UTC) #6

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/0e8d97c17b47d6ed6f4927eaf262a53e90c66541
Cr-Commit-Position: refs/heads/master@{#26464}