[Cleanup] Const-correct the profile() method for the EasyUnlockService

chrome/browser/chromeos/profiles/profile_helper.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
@@ skipping 91 matching lines @@
 }
 
 // static
 Profile* ProfileHelper::GetSigninProfile() {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   return profile_manager->GetProfile(GetSigninProfileDir())->
       GetOffTheRecordProfile();
 }
 
 // static
-std::string ProfileHelper::GetUserIdHashFromProfile(Profile* profile) {
+std::string ProfileHelper::GetUserIdHashFromProfile(const Profile* profile) {
   if (!profile)
     return std::string();
 
   std::string profile_dir = profile->GetPath().BaseName().value();
 
   // Don't strip prefix if the dir is not supposed to be prefixed.
   if (!ShouldAddProfileDirPrefix(profile_dir))
     return profile_dir;
 
   // Check that profile directory starts with the correct prefix.
@@ skipping 10 matching lines @@
 // static
 base::FilePath ProfileHelper::GetUserProfileDir(
     const std::string& user_id_hash) {
   CHECK(!user_id_hash.empty());
   return ShouldAddProfileDirPrefix(user_id_hash)
              ? base::FilePath(chrome::kProfileDirPrefix + user_id_hash)
              : base::FilePath(user_id_hash);
 }
 
 // static
-bool ProfileHelper::IsSigninProfile(Profile* profile) {
+bool ProfileHelper::IsSigninProfile(const Profile* profile) {
   return profile->GetPath().BaseName().value() == chrome::kInitialProfile;
 }
 
 // static
 bool ProfileHelper::IsOwnerProfile(Profile* profile) {
   if (!profile)
     return false;
-  user_manager::User* user = ProfileHelper::Get()->GetUserByProfile(profile);
+  const user_manager::User* user =
+      ProfileHelper::Get()->GetUserByProfile(profile);
   if (!user)
     return false;
 
   return user->email() == user_manager::UserManager::Get()->GetOwnerEmail();
 }
 
 // static
-bool ProfileHelper::IsPrimaryProfile(Profile* profile) {
+bool ProfileHelper::IsPrimaryProfile(const Profile* profile) {
   if (!profile)
     return false;
-  user_manager::User* user = ProfileHelper::Get()->GetUserByProfile(profile);
+  const user_manager::User* user =
+      ProfileHelper::Get()->GetUserByProfile(profile);
   if (!user)
     return false;
   return user == user_manager::UserManager::Get()->GetPrimaryUser();
 }
 
 void ProfileHelper::ProfileStartup(Profile* profile, bool process_startup) {
   // Initialize Chrome OS preferences like touch pad sensitivity. For the
   // preferences to work in the guest mode, the initialization has to be
   // done after |profile| is switched to the incognito profile (which
   // is actually GuestSessionProfile in the guest mode). See the
@@ skipping 80 matching lines @@
     profile = ProfileManager::GetActiveUserProfile();
   }
 
   // GetActiveUserProfile() or GetProfileByUserIdHash() returns a new instance
   // of ProfileImpl(), but actually its OffTheRecordProfile() should be used.
   if (profile && user_manager::UserManager::Get()->IsLoggedInAsGuest())
     profile = profile->GetOffTheRecordProfile();
   return profile;
 }
 
-user_manager::User* ProfileHelper::GetUserByProfile(Profile* profile) {
+const user_manager::User* ProfileHelper::GetUserByProfile(
+    const Profile* profile) const {
   // This map is non-empty only in tests.
   if (enable_profile_to_user_testing || !user_list_for_testing_.empty()) {
     if (always_return_primary_user_for_testing)
-      return const_cast<user_manager::User*>(
-          user_manager::UserManager::Get()->GetPrimaryUser());
+      return user_manager::UserManager::Get()->GetPrimaryUser();
 
     const std::string& user_name = profile->GetProfileUserName();
     for (user_manager::UserList::const_iterator it =
              user_list_for_testing_.begin();
          it != user_list_for_testing_.end();
          ++it) {
       if ((*it)->email() == user_name)
         return *it;
     }
 
     // In case of test setup we should always default to primary user.
-    return const_cast<user_manager::User*>(
-        user_manager::UserManager::Get()->GetPrimaryUser());
+    return user_manager::UserManager::Get()->GetPrimaryUser();
   }
 
   DCHECK(!content::BrowserThread::IsThreadInitialized(
              content::BrowserThread::UI) ||
          content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (ProfileHelper::IsSigninProfile(profile))
     return NULL;
 
   user_manager::UserManager* user_manager = user_manager::UserManager::Get();
 
@@ skipping 15 matching lines @@
       users.begin(), users.end(), UsernameHashMatcher(username_hash));
   if (pos != users.end())
     return *pos;
 
   // Many tests do not have their users registered with UserManager and
   // runs here. If |active_user_| matches |profile|, returns it.
   const user_manager::User* active_user = user_manager->GetActiveUser();
   return active_user &&
                  ProfileHelper::GetProfilePathByUserIdHash(
                      active_user->username_hash()) == profile->GetPath()
-             ? const_cast<user_manager::User*>(active_user)
+             ? active_user
              : NULL;
 }
 
+user_manager::User* ProfileHelper::GetUserByProfile(Profile* profile) const {
+  return const_cast<user_manager::User*>(
+      GetUserByProfile(static_cast<const Profile*>(profile)));
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // ProfileHelper, BrowsingDataRemover::Observer implementation:
 
 void ProfileHelper::OnBrowsingDataRemoverDone() {
   signin_profile_clear_requested_ = false;
   for (size_t i = 0; i < on_clear_callbacks_.size(); ++i) {
     if (!on_clear_callbacks_[i].is_null())
       on_clear_callbacks_[i].Run();
   }
   on_clear_callbacks_.clear();
@@ skipping 45 matching lines @@
   user_to_profile_for_testing_[user] = profile;
 }
 
 // static
 std::string ProfileHelper::GetUserIdHashByUserIdForTesting(
     const std::string& user_id) {
   return user_id + kUserIdHashSuffix;
 }
 
 }  // namespace chromeos