Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 897983003: Add test coverage for --prerender=disabled switch (Closed)

Created:
5 years, 10 months ago by dspell
Modified:
5 years, 10 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, jkarlin+watch_chromium.org, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test coverage for --prerender=disabled switch This adds a test to ensure that the disable switch is respected by ConfigurePrerender in prerender_field_trial.cc. BUG=455449 Committed: https://crrev.com/0fd78680ee76c85d5cf9eec9c15a30a99d0520a3 Cr-Commit-Position: refs/heads/master@{#315336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dspell
Hello cbentzel, this is a proposed test for BUG=455449. Can you take a look when ...
5 years, 10 months ago (2015-02-05 00:25:49 UTC) #2
cbentzel
LGTM Apologies for delay
5 years, 10 months ago (2015-02-09 13:25:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897983003/1
5 years, 10 months ago (2015-02-09 17:15:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 17:56:36 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 17:57:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fd78680ee76c85d5cf9eec9c15a30a99d0520a3
Cr-Commit-Position: refs/heads/master@{#315336}

Powered by Google App Engine
This is Rietveld 408576698