Issue 897973003: Have snapshot_test_lib depend on compat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 897973003: Have snapshot_test_lib depend on compat (Closed)

Created:
5 years, 10 months ago by scottmg

Modified:
5 years, 10 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@mindump_test-5

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Have snapshot_test_lib depend on compat Needed on Windows for sys/time.h. d:\src\crashpad\crashpad\snapshot\test\test_process_snapshot.h(19) : fatal error C1083: Cannot open include file: 'sys/time.h': No such file or directory R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/db99fdb462aa528278a226e0444a7bc40c0059c0

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	snapshot/snapshot.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

LGTM. This change was also in https://codereview.chromium.org/895313004/.

5 years, 10 months ago (2015-02-05 14:22:21 UTC) #2

scottmg

5 years, 10 months ago (2015-02-05 16:42:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
db99fdb462aa528278a226e0444a7bc40c0059c0 (presubmit successful).