[SkSVGDevice] Add support for more stroke params

[SkSVGDevice] Add support for more stroke params

stroke-linecap, stroke-linejoin, stroke-miterlimit, non-scaling-stroke.

R=mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/12753ccc9a3a096a8b528fab6dfed431eb9aa8b8

[f(malita), 2015-02-04 22:31:40]

fmalita@chromium.org changed reviewers:
+ reed@google.com

[mtklein, 2015-02-04 22:37:50]

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
File experimental/svg/SkSVGDevice.cpp (right):

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
experimental/svg/SkSVGDevice.cpp:42: static SkString svg_cap(SkPaint::Cap cap) {
Why don't these just return const char* ?  Seems like addAttribute() likes that
just fine, even prefers it.

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
experimental/svg/SkSVGDevice.cpp:225: this->addAttribute("fill", "none");
Can we assert kStroke_Style here?

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
experimental/svg/SkSVGDevice.cpp:257: this->addAttribute("stroke", "none");
And kFill_Style here?

[reed1, 2015-02-04 22:42:01]

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
File experimental/svg/SkSVGDevice.cpp (right):

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
experimental/svg/SkSVGDevice.cpp:42: static SkString svg_cap(SkPaint::Cap cap) {
On 2015/02/04 22:37:49, mtklein wrote:
> Why don't these just return const char* ?  Seems like addAttribute() likes
that
> just fine, even prefers it.

+1

[f(malita), 2015-02-04 22:43:14]

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
File experimental/svg/SkSVGDevice.cpp (right):

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
experimental/svg/SkSVGDevice.cpp:42: static SkString svg_cap(SkPaint::Cap cap) {
On 2015/02/04 22:37:49, mtklein wrote:
> Why don't these just return const char* ?  Seems like addAttribute() likes
that
> just fine, even prefers it.

Done.

https://codereview.chromium.org/897953004/diff/1/experimental/svg/SkSVGDevice...
experimental/svg/SkSVGDevice.cpp:225: this->addAttribute("fill", "none");
On 2015/02/04 22:37:49, mtklein wrote:
> Can we assert kStroke_Style here?

Done.

[mtklein, 2015-02-04 22:46:35]

lgtm

https://codereview.chromium.org/897953004/diff/20001/experimental/svg/SkSVGDe...
File experimental/svg/SkSVGDevice.cpp (right):

https://codereview.chromium.org/897953004/diff/20001/experimental/svg/SkSVGDe...
experimental/svg/SkSVGDevice.cpp:241: if (SkToBool(cap)) {
If you're feeling frisky, these can be

if (const char* cap = svg_cap(paint.getStrokeCap())) {
   this->addAttribute("stroke-linecap", cap);
}

etc.

One of the few ways C++ improved on C.  :P

https://codereview.chromium.org/897953004/diff/20001/experimental/svg/SkSVGDe...
experimental/svg/SkSVGDevice.cpp:258: SkASSERT(style == SkPaint::kFill_Style);
May be a stray space here?

[f(malita), 2015-02-04 22:50:26]

New patchsets have been uploaded after l-g-t-m from mtklein@google.com

[f(malita), 2015-02-04 22:50:52]

https://codereview.chromium.org/897953004/diff/20001/experimental/svg/SkSVGDe...
File experimental/svg/SkSVGDevice.cpp (right):

https://codereview.chromium.org/897953004/diff/20001/experimental/svg/SkSVGDe...
experimental/svg/SkSVGDevice.cpp:241: if (SkToBool(cap)) {
On 2015/02/04 22:46:35, mtklein wrote:
> If you're feeling frisky, these can be
> 
> if (const char* cap = svg_cap(paint.getStrokeCap())) {
>    this->addAttribute("stroke-linecap", cap);
> }
> 
> etc.
> 
> One of the few ways C++ improved on C.  :P

Done.

https://codereview.chromium.org/897953004/diff/20001/experimental/svg/SkSVGDe...
experimental/svg/SkSVGDevice.cpp:258: SkASSERT(style == SkPaint::kFill_Style);
On 2015/02/04 22:46:35, mtklein wrote:
> May be a stray space here?

Done.

[f(malita), 2015-02-04 22:50:54]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-02-04 22:51:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/897953004/40001

[commit-bot: I haz the power, 2015-02-04 22:56:39]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/12753ccc9a3a096a8b528fab6dfed431eb9aa8b8