Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 897943003: Remove unused base::NthType (Closed)

Created:
5 years, 10 months ago by tzik
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused base::NthType base::NthType was once added in a prototype of base::Bind refactoring though it is no longer used in the final code. BUG=433164 Committed: https://crrev.com/b953d843e9d8b2086e9b093c9a45003e38fd944f Cr-Commit-Position: refs/heads/master@{#315337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M base/bind_helpers.h View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
PTAL, I forgot to remove an unused template from the previous CL.
5 years, 10 months ago (2015-02-09 07:41:15 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-09 14:16:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897943003/1
5 years, 10 months ago (2015-02-09 15:06:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 17:57:06 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 17:58:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b953d843e9d8b2086e9b093c9a45003e38fd944f
Cr-Commit-Position: refs/heads/master@{#315337}

Powered by Google App Engine
This is Rietveld 408576698