Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 897923002: Revert of [OSX] Allow one zoom bubble to override another. (Closed)

Created:
5 years, 10 months ago by erikchen
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [OSX] Allow one zoom bubble to override another. (patchset #1 id:1 of https://codereview.chromium.org/886883002/) Reason for revert: Causes window flickering: https://code.google.com/p/chromium/issues/detail?id=455184 Original issue's description: > [OSX] Allow one zoom bubble to override another. > > At present, if a user changes zoom on OSX while the zoom bubble is > already being shown, the new zoom bubble (with the most up to date > information) is not shown. This CL changes this behaviour by allowing > a new zoom bubble to be created, and replace the existing one. > > Example: load a PDF and repeatedly click the zoom +/- controls in the > lower-right corner of the viewer. > > BUG=444995 > > Committed: https://crrev.com/84567ceada9f89c8e962d18ab494b1d1bb5a3830 > Cr-Commit-Position: refs/heads/master@{#314147} TBR=rohitrao@chromium.org,wjmaclean@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444995 Committed: https://crrev.com/7f84e128cc1e81d046423e8329c3f1767946f05e Cr-Commit-Position: refs/heads/master@{#314608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -21 lines) Patch
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm View 3 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of [OSX] Allow one zoom bubble to override another.
5 years, 10 months ago (2015-02-04 19:32:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897923002/1
5 years, 10 months ago (2015-02-04 19:33:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 19:34:40 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 19:35:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f84e128cc1e81d046423e8329c3f1767946f05e
Cr-Commit-Position: refs/heads/master@{#314608}

Powered by Google App Engine
This is Rietveld 408576698