Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 897903003: Ship kasko.dll with SyzyASAN instrumented Chrome. (Closed)

Created:
5 years, 10 months ago by erikwright (departed)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Sigurður Ásgeirsson, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@chrome_watcher_initialization_event
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship kasko.dll with SyzyASAN instrumented Chrome. BUG= Committed: https://crrev.com/563c5ffcbb14c5f639781db4d33d2bdacd2b7fab Cr-Commit-Position: refs/heads/master@{#314579}

Patch Set 1 #

Patch Set 2 : Review feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M chrome/chrome_syzygy.gyp View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
erikwright (departed)
grt: PTAL. Is this everything I need to do? Please see http://cl/83783735 for the corresponding ...
5 years, 10 months ago (2015-02-04 16:16:09 UTC) #2
grt (UTC plus 2)
If this file is to be installed on users' machines, then it also needs to ...
5 years, 10 months ago (2015-02-04 16:21:03 UTC) #3
erikwright (departed)
PTAL.
5 years, 10 months ago (2015-02-04 16:23:46 UTC) #4
Sigurður Ásgeirsson
lgtm
5 years, 10 months ago (2015-02-04 16:27:13 UTC) #6
grt (UTC plus 2)
lgtm
5 years, 10 months ago (2015-02-04 16:32:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897903003/20001
5 years, 10 months ago (2015-02-04 16:34:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 18:00:22 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:01:08 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/563c5ffcbb14c5f639781db4d33d2bdacd2b7fab
Cr-Commit-Position: refs/heads/master@{#314579}

Powered by Google App Engine
This is Rietveld 408576698