UserManager: set user.supervisedUser only for legacy supervised users

UserManager: set user.supervisedUser only for legacy supervised users

Since https://codereview.chromium.org/899663003, child accounts would get both the "supervised user" and the "child" icons. This CL fixes that.

Committed: https://crrev.com/029b5ce9ae94d3bb9c92945ac5a8f217954c11a9
Cr-Commit-Position: refs/heads/master@{#314573}

[Marc Treib, 2015-02-04 15:35:27]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org, merkulova@chromium.org

[Marc Treib, 2015-02-04 15:35:28]

PTAL!

[Bernhard Bauer, 2015-02-04 16:03:32]

https://codereview.chromium.org/897903002/diff/1/chrome/browser/ui/webui/sign...
File chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (right):

https://codereview.chromium.org/897903002/diff/1/chrome/browser/ui/webui/sign...
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:731:
kKeySupervisedUser, info_cache.ProfileIsLegacySupervisedAtIndex(i));
Hm... usually we use IsSupervised to mean both legacy-supervised users and child
accounts. If we do this, could we rename the key to kKeyLegacySupervisedUser, so
it's clear?

[merkulova, 2015-02-04 16:26:37]

lgtm for the fix
I'll take the renaming part.

https://codereview.chromium.org/897903002/diff/1/chrome/browser/ui/webui/sign...
File chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (right):

https://codereview.chromium.org/897903002/diff/1/chrome/browser/ui/webui/sign...
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:731:
kKeySupervisedUser, info_cache.ProfileIsLegacySupervisedAtIndex(i));
Agree with Bernhard. 
There's clearly some ambiguity for 'supervised'. I'll prepare a CL that will
help with renaming to legacySupervised.

[Bernhard Bauer, 2015-02-04 16:28:20]

LGTM then.

[Marc Treib, 2015-02-04 16:31:15]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2015-02-04 16:31:45]

Thanks Tatiana! Committing then :)

[commit-bot: I haz the power, 2015-02-04 16:32:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/897903002/1

[commit-bot: I haz the power, 2015-02-04 17:22:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-04 17:22:56]

Patchset 1 (id:??) landed as
https://crrev.com/029b5ce9ae94d3bb9c92945ac5a8f217954c11a9
Cr-Commit-Position: refs/heads/master@{#314573}