Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/compiler/graph.cc

Issue 897883002: [turbofan]: Improved source position information (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler/graph.h ('K') | « src/compiler/graph.h ('k') | src/compiler/pipeline.cc » ('j') | src/compiler/pipeline.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph.cc
diff --git a/src/compiler/graph.cc b/src/compiler/graph.cc
index 1650bdfdd76a57d1c17e6546518701438f0f1d36..4bba13e30384142fb95f7a76159dd16873ad016f 100644
--- a/src/compiler/graph.cc
+++ b/src/compiler/graph.cc
@@ -22,8 +22,9 @@ Graph::Graph(Zone* zone)
decorators_(zone) {}
-void Graph::Decorate(Node* node) {
- for (auto const decorator : decorators_) decorator->Decorate(node);
+void Graph::Decorate(Node* node, bool incomplete) {
+ for (auto const decorator : decorators_)
+ decorator->Decorate(node, incomplete);
Michael Starzinger 2015/02/04 13:54:03 nit: Can we put curly braces around the body?
danno 2015/02/04 14:04:59 Done.
}
@@ -44,7 +45,7 @@ Node* Graph::NewNode(const Operator* op, int input_count, Node** inputs,
DCHECK_LE(op->ValueInputCount(), input_count);
Node* const node =
Node::New(zone(), NextNodeId(), op, input_count, inputs, incomplete);
- if (!incomplete) Decorate(node);
+ Decorate(node, incomplete);
return node;
}
« src/compiler/graph.h ('K') | « src/compiler/graph.h ('k') | src/compiler/pipeline.cc » ('j') | src/compiler/pipeline.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698