Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: src/compiler/simplified-lowering.h

Issue 897883002: [turbofan]: Improved source position information (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/simplified-lowering.h
diff --git a/src/compiler/simplified-lowering.h b/src/compiler/simplified-lowering.h
index b21cf21ffdfe4cc94ea3050867bb8ad1dd4f3370..11506e9ac01e6867ccd023a88bd67861953c3552 100644
--- a/src/compiler/simplified-lowering.h
+++ b/src/compiler/simplified-lowering.h
@@ -16,12 +16,13 @@ namespace compiler {
// Forward declarations.
class RepresentationChanger;
-
+class SourcePositionTable;
class SimplifiedLowering FINAL {
public:
- SimplifiedLowering(JSGraph* jsgraph, Zone* zone)
- : jsgraph_(jsgraph), zone_(zone) {}
+ SimplifiedLowering(JSGraph* jsgraph, Zone* zone,
+ SourcePositionTable* source_positions)
+ : jsgraph_(jsgraph), zone_(zone), source_positions_(source_positions) {}
~SimplifiedLowering() {}
void LowerAllNodes();
@@ -45,6 +46,13 @@ class SimplifiedLowering FINAL {
JSGraph* const jsgraph_;
Zone* const zone_;
+ // TODO(danno): SimplifiedLowering shouldn't know anything about the source
+ // positions table, but must for now since there currently is no other way to
+ // pass down source position information to nodes created during
+ // lowering. Once this phase becomes a vanilla reducer, it should get source
+ // position information via the SourcePositionWrapper like all other reducers.
+ SourcePositionTable* source_positions_;
+
Node* SmiTag(Node* node);
Node* IsTagged(Node* node);
Node* Untag(Node* node);
« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698