[turbofan]: Improved source position information

src/compiler/graph.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_GRAPH_H_
 #define V8_COMPILER_GRAPH_H_
 
 #include "src/zone.h"
 #include "src/zone-containers.h"
 
@@ skipping 64 matching lines @@
 
   Zone* zone() const { return zone_; }
   Node* start() const { return start_; }
   Node* end() const { return end_; }
 
   void SetStart(Node* start) { start_ = start; }
   void SetEnd(Node* end) { end_ = end; }
 
   int NodeCount() const { return next_node_id_; }
 
-  void Decorate(Node* node);
+  void Decorate(Node* node, bool incomplete);

[titzer, 2015/02/04 13:46:19]

Is this incomplete flag necessary for source positions? Seems like there is an
unrelated change to the typer included in this CL.

[danno, 2015/02/04 14:04:59]

Nope, this is intended. Note that previously Decorators were not called when
nodes were incomplete. This was because the typer didn't want to type some
"incomplete" nodes. However, the source position decorator _always_ wants to be
invoked, even for incomplete nodes.  

   void AddDecorator(GraphDecorator* decorator);
   void RemoveDecorator(GraphDecorator* decorator);
 
  private:
   friend class NodeMarkerBase;
 
   inline NodeId NextNodeId();
 
   Zone* const zone_;
   Node* start_;
   Node* end_;
   Mark mark_max_;
   NodeId next_node_id_;
   ZoneVector<GraphDecorator*> decorators_;
 
   DISALLOW_COPY_AND_ASSIGN(Graph);
 };
 
 
 // A graph decorator can be used to add behavior to the creation of nodes
 // in a graph.
 class GraphDecorator : public ZoneObject {
  public:
   virtual ~GraphDecorator() {}
-  virtual void Decorate(Node* node) = 0;
+  virtual void Decorate(Node* node, bool incomplete) = 0;
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_GRAPH_H_