Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: components/update_client/test/test_installer.h

Issue 897873002: Make ComponentInstaller refcounted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@2015_01_19_component_installer
Patch Set: fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/update_client/test/test_installer.h
diff --git a/components/update_client/test/test_installer.h b/components/update_client/test/test_installer.h
index 933fe21372afe818c7ec88ec07a73cd744c714d3..2d9ae9faf70a7394740c93bc994654f95f33c7ed 100644
--- a/components/update_client/test/test_installer.h
+++ b/components/update_client/test/test_installer.h
@@ -31,11 +31,17 @@ class TestInstaller : public ComponentInstaller {
bool GetInstalledFile(const std::string& file,
base::FilePath* installed_file) override;
- int error() const;
+ int error() const {
+ return error_;
+ }
- int install_count() const;
+ int install_count() const {
+ return install_count_;
+ }
protected:
+ ~TestInstaller() override;
+
int error_;
int install_count_;
};
@@ -46,12 +52,12 @@ class ReadOnlyTestInstaller : public TestInstaller {
public:
explicit ReadOnlyTestInstaller(const base::FilePath& installed_path);
- ~ReadOnlyTestInstaller() override;
-
bool GetInstalledFile(const std::string& file,
base::FilePath* installed_file) override;
private:
+ ~ReadOnlyTestInstaller() override;
+
base::FilePath install_directory_;
};
@@ -61,8 +67,6 @@ class VersionedTestInstaller : public TestInstaller {
public:
VersionedTestInstaller();
- ~VersionedTestInstaller() override;
-
bool Install(const base::DictionaryValue& manifest,
const base::FilePath& unpack_path) override;
@@ -70,6 +74,8 @@ class VersionedTestInstaller : public TestInstaller {
base::FilePath* installed_file) override;
private:
+ ~VersionedTestInstaller() override;
+
base::FilePath install_directory_;
Version current_version_;
};
« no previous file with comments | « components/update_client/test/component_patcher_unittest.cc ('k') | components/update_client/test/test_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698