Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: components/update_client/component_unpacker.h

Issue 897873002: Make ComponentInstaller refcounted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@2015_01_19_component_installer
Patch Set: fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/update_client/component_unpacker.h
diff --git a/components/update_client/component_unpacker.h b/components/update_client/component_unpacker.h
index 7c2b6efcebbfcbf554eb91b153b0aa3d231a4fb5..033fd33bdd2c097d6acd2adae7fa32fc7828304a 100644
--- a/components/update_client/component_unpacker.h
+++ b/components/update_client/component_unpacker.h
@@ -95,12 +95,13 @@ class ComponentUnpacker : public base::RefCountedThreadSafe<ComponentUnpacker> {
// Constructs an unpacker for a specific component unpacking operation.
// |pk_hash| is the expected/ public key SHA256 hash. |path| is the current
// location of the CRX.
- ComponentUnpacker(const std::vector<uint8_t>& pk_hash,
- const base::FilePath& path,
- const std::string& fingerprint,
- ComponentInstaller* installer,
- scoped_refptr<OutOfProcessPatcher> oop_patcher,
- scoped_refptr<base::SequencedTaskRunner> task_runner);
+ ComponentUnpacker(
+ const std::vector<uint8_t>& pk_hash,
+ const base::FilePath& path,
+ const std::string& fingerprint,
+ const scoped_refptr<ComponentInstaller>& installer,
+ const scoped_refptr<OutOfProcessPatcher>& oop_patcher,
+ const scoped_refptr<base::SequencedTaskRunner>& task_runner);
// Begins the actual unpacking of the files. May invoke a patcher if the
// package is a differential update. Calls |callback| with the result.
@@ -147,7 +148,7 @@ class ComponentUnpacker : public base::RefCountedThreadSafe<ComponentUnpacker> {
bool is_delta_;
std::string fingerprint_;
scoped_refptr<ComponentPatcher> patcher_;
- ComponentInstaller* installer_;
+ scoped_refptr<ComponentInstaller> installer_;
Callback callback_;
scoped_refptr<OutOfProcessPatcher> oop_patcher_;
Error error_;
« no previous file with comments | « components/update_client/component_patcher_operation.cc ('k') | components/update_client/component_unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698