components/component_updater/default_component_installer.h - Issue 897873002: Make ComponentInstaller refcounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/default_component_installer.h

Issue 897873002: Make ComponentInstaller refcounted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@2015_01_19_component_installer

Patch Set: fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/component_updater/component_updater_service.cc ('k') | components/component_updater/default_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/default_component_installer.h

diff --git a/components/component_updater/default_component_installer.h b/components/component_updater/default_component_installer.h

index 120d3a5de8cd44ae484120ee7633aa326e7661cd..8a39993bb970d0c6961df4b265692808cf734dbc 100644

--- a/components/component_updater/default_component_installer.h

+++ b/components/component_updater/default_component_installer.h

@@ -99,15 +99,16 @@ class DefaultComponentInstaller : public update_client::ComponentInstaller {

bool GetInstalledFile(const std::string& file,

base::FilePath* installed_file) override;

+ private:

~DefaultComponentInstaller() override;

- private:

base::FilePath GetInstallDirectory();

bool InstallHelper(const base::DictionaryValue& manifest,

const base::FilePath& unpack_path,

const base::FilePath& install_path);

void StartRegistration(ComponentUpdateService* cus);

void FinishRegistration(ComponentUpdateService* cus);

+ void ComponentReady(scoped_ptr<base::DictionaryValue> manifest);

base::Version current_version_;

std::string current_fingerprint_;