chrome/browser/component_updater/swiftshader_component_installer.cc - Issue 897873002: Make ComponentInstaller refcounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/swiftshader_component_installer.cc

Issue 897873002: Make ComponentInstaller refcounted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@2015_01_19_component_installer

Patch Set: fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/supervised_user_whitelist_installer.cc ('k') | chrome/browser/component_updater/test/component_updater_service_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/swiftshader_component_installer.cc

diff --git a/chrome/browser/component_updater/swiftshader_component_installer.cc b/chrome/browser/component_updater/swiftshader_component_installer.cc

index bea146a5a94c9671c38d004b098e412c28718d0c..917a3ca4c86e8d054c08de148169124678716168 100644

--- a/chrome/browser/component_updater/swiftshader_component_installer.cc

+++ b/chrome/browser/component_updater/swiftshader_component_installer.cc

@@ -100,8 +100,7 @@ class SwiftShaderComponentInstaller : public update_client::ComponentInstaller {

public:

explicit SwiftShaderComponentInstaller(const Version& version);

- ~SwiftShaderComponentInstaller() override {}

+ // ComponentInstaller implementation:

void OnUpdateError(int error) override;

bool Install(const base::DictionaryValue& manifest,

@@ -111,6 +110,8 @@ class SwiftShaderComponentInstaller : public update_client::ComponentInstaller {

base::FilePath* installed_file) override;

private:

+ ~SwiftShaderComponentInstaller() override {}

Version current_version_;

};