chrome/browser/component_updater/recovery_component_installer.cc - Issue 897873002: Make ComponentInstaller refcounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/recovery_component_installer.cc

Issue 897873002: Make ComponentInstaller refcounted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@2015_01_19_component_installer

Patch Set: fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/pnacl/pnacl_component_installer.cc ('k') | chrome/browser/component_updater/supervised_user_whitelist_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/recovery_component_installer.cc

diff --git a/chrome/browser/component_updater/recovery_component_installer.cc b/chrome/browser/component_updater/recovery_component_installer.cc

index 2173f05f0cff4a1e4be4ebf7486c1eb1c798b616..696ab4328c295a07084999cc5bd4b75e46d7e089 100644

--- a/chrome/browser/component_updater/recovery_component_installer.cc

+++ b/chrome/browser/component_updater/recovery_component_installer.cc

@@ -176,8 +176,8 @@ void ElevatedInstallRecoveryComponent(const base::FilePath& installer_path) {

class RecoveryComponentInstaller : public update_client::ComponentInstaller {

public:

RecoveryComponentInstaller(const Version& version, PrefService* prefs);

- ~RecoveryComponentInstaller() override {}

+ // ComponentInstaller implementation:

void OnUpdateError(int error) override;

bool Install(const base::DictionaryValue& manifest,

@@ -187,6 +187,8 @@ class RecoveryComponentInstaller : public update_client::ComponentInstaller {

base::FilePath* installed_file) override;

private:

+ ~RecoveryComponentInstaller() override {}

bool RunInstallCommand(const base::CommandLine& cmdline,

const base::FilePath& installer_folder) const;