chrome/browser/component_updater/pnacl/pnacl_component_installer.h - Issue 897873002: Make ComponentInstaller refcounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/pnacl/pnacl_component_installer.h

Issue 897873002: Make ComponentInstaller refcounted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@2015_01_19_component_installer

Patch Set: fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/pepper_flash_component_installer.cc ('k') | chrome/browser/component_updater/pnacl/pnacl_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/pnacl/pnacl_component_installer.h

diff --git a/chrome/browser/component_updater/pnacl/pnacl_component_installer.h b/chrome/browser/component_updater/pnacl/pnacl_component_installer.h

index a5683bb910c7ac8d2cb3128917b8813567759392..b8e256dc4484e5abe753d6cfda353a6ddb4f3537 100644

--- a/chrome/browser/component_updater/pnacl/pnacl_component_installer.h

+++ b/chrome/browser/component_updater/pnacl/pnacl_component_installer.h

@@ -41,8 +41,7 @@ class PnaclComponentInstaller : public update_client::ComponentInstaller {

public:

PnaclComponentInstaller();

- ~PnaclComponentInstaller() override;

+ // ComponentInstaller implementation:

void OnUpdateError(int error) override;

bool Install(const base::DictionaryValue& manifest,

@@ -74,9 +73,12 @@ class PnaclComponentInstaller : public update_client::ComponentInstaller {

ComponentUpdateService* cus() const { return cus_; }

private:

+ ~PnaclComponentInstaller() override;

base::Version current_version_;

std::string current_fingerprint_;

ComponentUpdateService* cus_;

DISALLOW_COPY_AND_ASSIGN(PnaclComponentInstaller);

};