components/component_updater/component_updater_service.cc - Issue 897873002: Make ComponentInstaller refcounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/component_updater_service.cc

Issue 897873002: Make ComponentInstaller refcounted. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@2015_01_19_component_installer

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browser_process_impl.cc ('K') | « chrome/browser/net/crl_set_fetcher.h ('k') | components/component_updater/default_component_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/component_updater_service.cc

diff --git a/components/component_updater/component_updater_service.cc b/components/component_updater/component_updater_service.cc

index 4b97baeb31c81a2eedbf39ce8ede6ab7466056d7..89195c482f203701105671039219ff05c33fe8ee 100644

--- a/components/component_updater/component_updater_service.cc

+++ b/components/component_updater/component_updater_service.cc

@@ -108,7 +108,7 @@ class CrxUpdateService : public ComponentUpdateService, public OnDemandUpdater {

// Context for a crx download url request.

struct CRXContext {

- ComponentInstaller* installer;

+ scoped_refptr<ComponentInstaller> installer;

std::vector<uint8_t> pk_hash;

std::string id;

std::string fingerprint;

« chrome/browser/browser_process_impl.cc ('K') | « chrome/browser/net/crl_set_fetcher.h ('k') | components/component_updater/default_component_installer.h » ('j') | no next file with comments »