Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897863003: Fix the histograms whitelist for the OOP PDF plugin. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the histograms whitelist for the OOP PDF plugin. BUG=405305 Committed: https://crrev.com/ad1fecf3841f539281c8d6ff3a873bfc9c11571d Cr-Commit-Position: refs/heads/master@{#314764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/renderer/pepper/pepper_uma_host.cc View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
5 years, 10 months ago (2015-02-05 05:04:49 UTC) #2
raymes
lgtm! Thank you!
5 years, 10 months ago (2015-02-05 05:37:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897863003/1
5 years, 10 months ago (2015-02-05 06:14:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 06:18:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ad1fecf3841f539281c8d6ff3a873bfc9c11571d Cr-Commit-Position: refs/heads/master@{#314764}
5 years, 10 months ago (2015-02-05 06:19:14 UTC) #7
dcheng
5 years, 10 months ago (2015-02-05 08:12:47 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/901863002/ by dcheng@chromium.org.

The reason for reverting is: Introduced 2 new static initializers:

pepper_uma_host.cc (anonymous namespace)::kWhitelistedPluginBaseNames
pepper_uma_host.cc __init_array_end+0x5e8.

Powered by Google App Engine
This is Rietveld 408576698