|
|
Created:
5 years, 10 months ago by aurimas (slooooooooow) Modified:
5 years, 10 months ago CC:
chromium-reviews, darin-cc_chromium.org, gone, David Trainor- moved to gerrit, newt (away), Yusuf Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd more OWNERs to content/public/android
BUG=None
NOTRY=true
Committed: https://crrev.com/680879373111af996eb06886910a58af5c7538ca
Cr-Commit-Position: refs/heads/master@{#314598}
Patch Set 1 #
Messages
Total messages: 24 (8 generated)
aurimas@chromium.org changed reviewers: + tedchoc@chromium.org, yfriedman@chromium.org
tedchoc, yfriedman: PTAL. cc: dtrainor@chromium.org, newt@chromium.org, yusufo@chromium.org, dfalcantara@chromium.org as they get added to OWNERS
lgtm
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897803002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897803002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
The CQ bit was checked by aurimas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897803002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/680879373111af996eb06886910a58af5c7538ca Cr-Commit-Position: refs/heads/master@{#314598}
Message was sent while issue was closed.
On 2015/02/04 19:05:21, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as > https://crrev.com/680879373111af996eb06886910a58af5c7538ca > Cr-Commit-Position: refs/heads/master@{#314598} This is actually breaking android_aosp bot for reasons I cannot fathom..
Message was sent while issue was closed.
On 2015/02/04 19:31:09, boliu wrote: > On 2015/02/04 19:05:21, I haz the power (commit-bot) wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/680879373111af996eb06886910a58af5c7538ca > > Cr-Commit-Position: refs/heads/master@{#314598} > > This is actually breaking android_aosp bot for reasons I cannot fathom.. Bahh, can't even revert with "Revert Patchset"
Message was sent while issue was closed.
newt@chromium.org changed reviewers: + newt@chromium.org
Message was sent while issue was closed.
aapt freaks out because the res directory now contains an unexpected resource file: OWNERS. You can tell aapt to ignore the OWNERS file using the --ignore-assets option. E.g. aapt package .... --ignore-assets '!OWNERS:!.svn:!.git:!.ds_store:!*.scc:.*:<dir>_*:!CVS:!thumbs.db:!picasa.ini:!*~' See AAPT_IGNORE_PATTERN in build_utils.py and the places where AAPT_IGNORE_PATTERN is used.
Message was sent while issue was closed.
aurimas@chromium.org changed reviewers: + torne@chromium.org
Message was sent while issue was closed.
+torne@ who according to boliu@ handles resources in WebView. Can you make a change to WebView aapt step to ignore OWNERS files?
Message was sent while issue was closed.
for future reference, please don't use TBR again for stuff like this. The bot was obviously broken, as it failed a few times.
Message was sent while issue was closed.
On 2015/02/04 at 20:04:32, jam wrote: > for future reference, please don't use TBR again for stuff like this. The bot was obviously broken, as it failed a few times. I looked at the bot and saw that compile was failing. I was assuming it was a bot problem as OWNERS files are just static files that do not compile.
Message was sent while issue was closed.
On 2015/02/04 20:07:53, aurimas wrote: > On 2015/02/04 at 20:04:32, jam wrote: > > for future reference, please don't use TBR again for stuff like this. The bot > was obviously broken, as it failed a few times. > > I looked at the bot and saw that compile was failing. I was assuming it was a > bot problem as OWNERS files are just static files that do not compile. yeah, it's so hard to figure out what each build does in its compile or other steps. In cases where I see weird breakages like this, I look at other runs of the bots to know if something is busted. even if the tree is broken because of a bad commit, waiting for the CQ to retry is the best strategy. |