Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issue 897803002: Add more OWNERs to content/public/android (Closed)

Created:
5 years, 10 months ago by aurimas (slooooooooow)
Modified:
5 years, 10 months ago
Reviewers:
Ted C, Yaron, Torne, newt (away)
CC:
chromium-reviews, darin-cc_chromium.org, gone, David Trainor- moved to gerrit, newt (away), Yusuf
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more OWNERs to content/public/android BUG=None NOTRY=true Committed: https://crrev.com/680879373111af996eb06886910a58af5c7538ca Cr-Commit-Position: refs/heads/master@{#314598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --1 lines) Patch
M content/public/android/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + content/public/android/java/res/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
aurimas (slooooooooow)
tedchoc, yfriedman: PTAL. cc: dtrainor@chromium.org, newt@chromium.org, yusufo@chromium.org, dfalcantara@chromium.org as they get added to OWNERS
5 years, 10 months ago (2015-02-04 01:10:49 UTC) #2
Ted C
lgtm
5 years, 10 months ago (2015-02-04 16:37:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897803002/1
5 years, 10 months ago (2015-02-04 17:25:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/54912)
5 years, 10 months ago (2015-02-04 17:54:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897803002/1
5 years, 10 months ago (2015-02-04 18:20:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/54951)
5 years, 10 months ago (2015-02-04 18:47:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897803002/1
5 years, 10 months ago (2015-02-04 18:56:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 19:04:18 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/680879373111af996eb06886910a58af5c7538ca Cr-Commit-Position: refs/heads/master@{#314598}
5 years, 10 months ago (2015-02-04 19:05:21 UTC) #15
boliu
On 2015/02/04 19:05:21, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 10 months ago (2015-02-04 19:31:09 UTC) #16
boliu
On 2015/02/04 19:31:09, boliu wrote: > On 2015/02/04 19:05:21, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-04 19:35:32 UTC) #17
newt (away)
aapt freaks out because the res directory now contains an unexpected resource file: OWNERS. You ...
5 years, 10 months ago (2015-02-04 19:52:47 UTC) #19
aurimas (slooooooooow)
+torne@ who according to boliu@ handles resources in WebView. Can you make a change to ...
5 years, 10 months ago (2015-02-04 20:02:24 UTC) #21
jam
for future reference, please don't use TBR again for stuff like this. The bot was ...
5 years, 10 months ago (2015-02-04 20:04:32 UTC) #22
aurimas (slooooooooow)
On 2015/02/04 at 20:04:32, jam wrote: > for future reference, please don't use TBR again ...
5 years, 10 months ago (2015-02-04 20:07:53 UTC) #23
jam
5 years, 10 months ago (2015-02-04 20:13:32 UTC) #24
Message was sent while issue was closed.
On 2015/02/04 20:07:53, aurimas wrote:
> On 2015/02/04 at 20:04:32, jam wrote:
> > for future reference, please don't use TBR again for stuff like this. The
bot
> was obviously broken, as it failed a few times.
> 
> I looked at the bot and saw that compile was failing. I was assuming it was a
> bot problem as OWNERS files are just static files that do not compile.

yeah, it's so hard to figure out what each build does in its compile or other
steps. In cases where I see weird breakages like this, I look at other runs of
the bots to know if something is busted. even if the tree is broken because of a
bad commit, waiting for the CQ to retry is the best strategy.

Powered by Google App Engine
This is Rietveld 408576698