Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issue 897793002: Remove gcm channel state supported by sync service. (Closed)

Created:
5 years, 10 months ago by jianli
Modified:
5 years, 10 months ago
Reviewers:
Nicolas Zea, pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gcm channel state supported by sync service. This is not longer needed after we have a generic gcm channel state. BUG=447016 TEST=none TBR=kalman@chromium.org Committed: https://crrev.com/fe3a8bd7b8d88c746848973fc8b11bc880e586da Cr-Commit-Position: refs/heads/master@{#314695}

Patch Set 1 #

Patch Set 2 : Sync #

Patch Set 3 : Remove prefs #

Patch Set 4 : Fix android builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -86 lines) Patch
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/invalidation/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/invalidation/ticl_profile_settings_provider.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_syncer.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_channel_status_syncer.cc View 1 2 7 chunks +26 lines, -21 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M sync/internal_api/public/util/experiments.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jianli
5 years, 10 months ago (2015-02-04 00:52:06 UTC) #2
Nicolas Zea
+Pavel, as he added this I believe. The preference itself is staying around because we ...
5 years, 10 months ago (2015-02-04 18:39:07 UTC) #4
pavely
On 2015/02/04 18:39:07, Nicolas Zea wrote: > +Pavel, as he added this I believe. No, ...
5 years, 10 months ago (2015-02-04 22:44:59 UTC) #5
jianli
On 2015/02/04 22:44:59, pavely wrote: > On 2015/02/04 18:39:07, Nicolas Zea wrote: > > +Pavel, ...
5 years, 10 months ago (2015-02-04 23:01:32 UTC) #7
pavely
lgtm
5 years, 10 months ago (2015-02-05 00:00:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897793002/80001
5 years, 10 months ago (2015-02-05 00:32:37 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 10 months ago (2015-02-05 00:55:54 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:57:04 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fe3a8bd7b8d88c746848973fc8b11bc880e586da
Cr-Commit-Position: refs/heads/master@{#314695}

Powered by Google App Engine
This is Rietveld 408576698