Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 897783002: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jdduke+watch_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=aelias@chromium.org Committed: https://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd Cr-Commit-Position: refs/heads/master@{#314477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -182 lines) Patch
M content/browser/renderer_host/compositor_impl_android.h View 2 chunks +39 lines, -41 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_android.h View 1 chunk +26 lines, -26 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_android.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +94 lines, -99 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:51:27 UTC) #1
aelias_OOO_until_Jul13
lgtm
5 years, 10 months ago (2015-02-04 01:01:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897783002/1
5 years, 10 months ago (2015-02-04 01:12:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 02:26:59 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 02:29:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c09395ec838d73d66ff900bb4d471ce931b192bd
Cr-Commit-Position: refs/heads/master@{#314477}

Powered by Google App Engine
This is Rietveld 408576698