Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 897773002: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=skyostil@chromium.org Committed: https://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0 Cr-Commit-Position: refs/heads/master@{#314853}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -184 lines) Patch
M content/browser/android/browser_surface_texture_manager.h View 1 chunk +7 lines, -9 lines 0 comments Download
M content/browser/android/composited_touch_handle_drawable.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/android/content_settings.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 2 chunks +15 lines, -15 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_render_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/android/content_view_statics.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/android/download_controller_android_impl.h View 1 chunk +12 lines, -10 lines 0 comments Download
M content/browser/android/edge_effect.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/browser/android/edge_effect_l.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.h View 1 1 chunk +11 lines, -12 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.h View 2 chunks +16 lines, -18 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/android/interstitial_page_delegate_android.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/android/java/gin_java_bound_object_delegate.h View 1 chunk +7 lines, -9 lines 0 comments Download
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/android/java/gin_java_method_invocation_helper_unittest.cc View 6 chunks +23 lines, -27 lines 0 comments Download
M content/browser/android/java/jni_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/overscroll_controller_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/popup_touch_handle_drawable.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/android/web_contents_observer_android.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:50:48 UTC) #1
Sami
lgtm, thanks.
5 years, 10 months ago (2015-02-05 11:37:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897773002/1
5 years, 10 months ago (2015-02-05 18:04:23 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/55858) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/7799) ios_rel_device_ninja_ng ...
5 years, 10 months ago (2015-02-05 18:07:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897773002/20001
5 years, 10 months ago (2015-02-05 18:36:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 19:27:11 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 19:28:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0217ba51893ea7cc776d843d035bec759fef9a0
Cr-Commit-Position: refs/heads/master@{#314853}

Powered by Google App Engine
This is Rietveld 408576698