Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 897733002: worker: Use standard task-runners to run notification image loader callbacks. (Closed)

Created:
5 years, 10 months ago by sadrul
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

notifications: Use standard task-runners to run image loader callbacks. Instead of using the id of the worker-thread to keep track of the thread to run the image-loader callbacks on, use the task-runner of the thread instead. BUG=none R=mkwst@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/609de4573984d34743ce3e237855469a946a27d4

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M content/child/notifications/notification_image_loader.h View 3 chunks +10 lines, -4 lines 0 comments Download
M content/child/notifications/notification_image_loader.cc View 1 2 3 chunks +8 lines, -11 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
sadrul
5 years, 10 months ago (2015-02-03 23:41:37 UTC) #2
Mike West
It's not clear to me what effects this change will have. Why should we use ...
5 years, 10 months ago (2015-02-04 12:17:32 UTC) #3
Mike West
(Also, the bots seem to pretty consistently not like this change :) )
5 years, 10 months ago (2015-02-04 12:17:59 UTC) #4
sadrul
On 2015/02/04 12:17:32, Mike West wrote: > It's not clear to me what effects this ...
5 years, 10 months ago (2015-02-04 14:17:23 UTC) #5
sadrul
ping
5 years, 10 months ago (2015-02-06 15:50:19 UTC) #6
Mike West
LGTM.
5 years, 10 months ago (2015-02-06 17:07:00 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/609de4573984d34743ce3e237855469a946a27d4 Cr-Commit-Position: refs/heads/master@{#315109}
5 years, 10 months ago (2015-02-06 21:24:56 UTC) #8
sadrul
5 years, 10 months ago (2015-02-06 21:25:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
609de4573984d34743ce3e237855469a946a27d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698