content/public/browser/content_browser_client.h - Issue 897673002: First step in enabling creating tabs without an Activity on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.h

Issue 897673002: First step in enabling creating tabs without an Activity on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a-base-mounir

Patch Set: s/NavigationUtils/ServiceTabCreator/g Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/service_tab_creator.h ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/public/browser/content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.h

diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h

index 5e5d5d4296603604897ba802d38de83c0c8b3b70..11b5332aadb3daa63660b75c0adcf89141bec9ed 100644

--- a/content/public/browser/content_browser_client.h

+++ b/content/public/browser/content_browser_client.h

@@ -616,9 +616,11 @@ class CONTENT_EXPORT ContentBrowserClient {

WebContents* web_contents);

// Allows programmatic opening of a new tab/window without going through

- // another WebContents. For example, from a Worker.

- virtual WebContents* OpenURL(BrowserContext* browser_context,

- const OpenURLParams& params);

+ // another WebContents. For example, from a Worker. |callback| will be

+ // invoked with the appropriate WebContents* when available.

+ virtual void OpenURL(BrowserContext* browser_context,

+ const OpenURLParams& params,

+ base::Callback<void(WebContents*)> callback) {}

#if defined(OS_POSIX) && !defined(OS_MACOSX)

// Populates |mappings| with all files that need to be mapped before launching