chrome/browser/chrome_content_browser_client.h - Issue 897673002: First step in enabling creating tabs without an Activity on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 897673002: First step in enabling creating tabs without an Activity on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a-base-mounir

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java ('K') | « chrome/browser/android/service_tab_launcher.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/browser/chrome_content_browser_client_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.h

diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h

index 40e700f311f5a8e0a4f411c57f4cde31cd8cd317..a456f7b3ca5da77459ac57c3ddc3f9c21fbfa1da 100644

--- a/chrome/browser/chrome_content_browser_client.h

+++ b/chrome/browser/chrome_content_browser_client.h

@@ -281,8 +281,10 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {

const GURL& security_origin,

content::MediaStreamType type) override;

- content::WebContents* OpenURL(content::BrowserContext* browser_context,

- const content::OpenURLParams& params) override;

+ void OpenURL(content::BrowserContext* browser_context,

+ const content::OpenURLParams& params,

+ const base::Callback<void(content::WebContents*)>& callback)

+ override;

mlamouri (slow - plz ping) 2015/02/11 13:50:23 nit: override in its line alone, is that fine per

Peter Beverloo 2015/02/11 16:18:27 I don't see why not, it's a continuation with 4-sp

private:

friend class DisableWebRtcEncryptionFlagTest;