Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: content/public/browser/content_browser_client.cc

Issue 897673002: First step in enabling creating tabs without an Activity on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a-base-mounir
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/content_browser_client.cc
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
index acacd9850ca0507b98dbace2a9d72bc5eea76747..8f3d06c1edb4a140a334f6c7aa6f8b5d4f4ef25e 100644
--- a/content/public/browser/content_browser_client.cc
+++ b/content/public/browser/content_browser_client.cc
@@ -342,11 +342,6 @@ ContentBrowserClient::GetPresentationServiceDelegate(
return nullptr;
}
-WebContents* ContentBrowserClient::OpenURL(BrowserContext* browser_context,
- const OpenURLParams& params) {
- return nullptr;
mlamouri (slow - plz ping) 2015/02/09 12:07:37 May I suggest to keep a default implementation and
Peter Beverloo 2015/02/10 17:49:37 I'd prefer not to, as that breaks the API contract
mlamouri (slow - plz ping) 2015/02/11 13:50:23 How would they get NOTIMPLEMENTED()? That's in the
Peter Beverloo 2015/02/11 16:18:27 Right. That's true. I've added the "callback.Run(n
-}
-
#if defined(OS_WIN)
const wchar_t* ContentBrowserClient::GetResourceDllName() {
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698